Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rtl direction from carousel-slide to carousel-track #140

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Move rtl direction from carousel-slide to carousel-track #140

merged 1 commit into from
Feb 6, 2024

Conversation

azerozvn
Copy link
Contributor

@azerozvn azerozvn commented Feb 6, 2024

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Feb 6, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@netlify Netlify
Copy link

netlify bot commented Feb 6, 2024 •
edited
Loading

✅ Deploy Preview for vue-ssr-carousel ready!

Name Link
🔨 Latest commit b828a17
🔍 Latest deploy log https://app.netlify.com/sites/vue-ssr-carousel/deploys/65c17814a0325d0007b9a773
😎 Deploy Preview https://deploy-preview-140--vue-ssr-carousel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@azerozvn
Copy link
Contributor Author

azerozvn commented Feb 6, 2024

@weotch Just tagging you for visibility

@azerozvn azerozvn merged commit 1930286 into main Feb 6, 2024
5 of 7 checks passed
@azerozvn azerozvn deleted the fix-rtl-direction-in-track branch February 6, 2024 00:09
weotch
weotch reviewed Feb 6, 2024
View reviewed changes
src/ssr-carousel-track.vue
Comment on lines +201 to +204
// Apply direction property which was reset in .ssr-carousel
&.ssr-carousel-rtl
direction rtl

Copy link
Member

@weotch weotch Feb 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought this would mess up the layout of the slides on the track. Also, the carousel looks broke on the deploy preview: https://deploy-preview-140--vue-ssr-carousel.netlify.app/accessibility/

vue-ssr-carousel demo 2024-02-05 at 4 23 23 PM jpg

You sure about this change?

weotch added a commit that referenced this pull request Feb 20, 2024
@weotch
Revert "2.4.2"
382be0e 
This reverts commit 6004e4d.

Revert "Merge pull request #140 from BKWLD/fix-rtl-direction-in-track"

This reverts commit 1930286, reversing
changes made to 7de39ba.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weotch weotch weotch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azerozvn @weotch